Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Support @template.function("name") definitions #7183

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Oct 2, 2023

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner October 2, 2023 18:52
@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Oct 2, 2023 6:52pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2023 6:52pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2023 6:52pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2023 6:52pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2023 6:52pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2023 6:52pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2023 6:52pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2023 6:52pm

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e7043bb) 47.06% compared to head (2c20f8c) 71.20%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7183       +/-   ##
===========================================
+ Coverage   47.06%   71.20%   +24.13%     
===========================================
  Files         155      323      +168     
  Lines       20749    53748    +32999     
  Branches     5216     5216               
===========================================
+ Hits         9766    38271    +28505     
- Misses      10664    15158     +4494     
  Partials      319      319               
Flag Coverage Δ
cube-backend 47.06% <ø> (ø)
cubesql 86.38% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 168 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltiunov paveltiunov merged commit 33823e8 into master Oct 2, 2023
@paveltiunov paveltiunov deleted the python-function-name branch October 2, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant