feat(vertica-driver): VerticaDriver

[timbrownls20]

Check List

• Tests has been run in packages where changes made if available
• Linter has been run for changed code
• Tests for the changes have been added if not covered yet
• Docs have been added / updated if required

Issue Reference this PR resolves

[#690]

Description of Changes Made (if issue reference is not provided)

New @cubejs-backend/vertica-driver package based on vertica-nodejs -- it includes driver itself and basic tests for overridden BaseDriver methods.

published to npm npm i @knowitall/vertica-driver

continuation of this stale PR #5100

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
examples-angular-dashboard	⬜️ Ignored (Inspect)	Visit Preview		Dec 2, 2024 0:50am
examples-react-d3	⬜️ Ignored (Inspect)	Visit Preview		Dec 2, 2024 0:50am
examples-react-dashboard	⬜️ Ignored (Inspect)	Visit Preview		Dec 2, 2024 0:50am
examples-react-data-table	⬜️ Ignored (Inspect)	Visit Preview		Dec 2, 2024 0:50am
examples-react-highcharts	⬜️ Ignored (Inspect)	Visit Preview		Dec 2, 2024 0:50am
examples-react-material-ui	⬜️ Ignored (Inspect)	Visit Preview		Dec 2, 2024 0:50am
examples-react-pivot-table	⬜️ Ignored (Inspect)	Visit Preview		Dec 2, 2024 0:50am
examples-vue-query-builder	⬜️ Ignored (Inspect)	Visit Preview		Dec 2, 2024 0:50am

[paveltiunov]

@timbrownls20 Thanks for contributing! Could you please write a readme on your npm package on how to install and use it? We'll add a backlink to it in the third-party driver list.

[timbrownls20]

@timbrownls20 Thanks for contributing! Could you please write a readme on your npm package on how to install and use it? We'll add a backlink to it in the third-party driver list.

No problem. Added instructions to README for the npm package. Wasn't sure what you wanted, so hope this is OK. If you need amends could you post a link to an example. Many Thanks

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.04%. Comparing base (5a27200) to head (ea68485).
Report is 32 commits behind head on master.

❗ Current head ea68485 differs from pull request most recent head 04334c0. Consider uploading reports for the commit 04334c0 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7289      +/-   ##
==========================================
- Coverage   48.02%   47.04%   -0.99%     
==========================================
  Files         154      155       +1     
  Lines       21019    20768     -251     
  Branches     5264     5224      -40     
==========================================
- Hits        10095     9770     -325     
+ Misses      10723    10678      -45     
- Partials      201      320     +119     

Flag	Coverage Δ
cube-backend	47.04% <ø> (-0.99%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[paveltiunov]

@timbrownls20 I actually meant README of @knowitall/vertica-driver. Please see the process here https://github.com/cube-js/cube/blob/master/CONTRIBUTING.md#contributing-database-drivers. You can see https://www.npmjs.com/package/arangodb-cubejs-driver as an example.

[timbrownls20]

Hi @igorlukanin. We've just brought the driver back uptodate with version 0.36.0. If possible we'd like to get this merged into the main branch - anything else we would need to do? Many Thanks

[timbrownls20]

Updated to version 0.36.5 to bring in fixes for two FILTER_PARAMS issues

[igorlukanin]

@timbrownls20 May I kindly ask you to add a page to the docs?

We have a list of supported data sources with linked pages for individual tools, e.g., Postgres. You can find the source code in the same repo: https://github.com/cube-js/cube/tree/master/docs/pages/product/configuration

It would be great if you can add a page for Vertical as well.

You can use this as an icon: https://static.cube.dev/icons/vertica.svg

[KSDaemon]

@timbrownls20 Can you please run yarn run lint:fix to fix most of the code style warnings that arose? and it would be cool if you fix the rest too. Thnx!

[timbrownls20]

@timbrownls20 Can you please run yarn run lint:fix to fix most of the code style warnings that arose? and it would be cool if you fix the rest too. Thnx!

No probs - I've fixed some lint issues to other files within the packages that I'd changed. Hope that's what you meant. Cheers

[timbrownls20]

@timbrownls20 May I kindly ask you to add a page to the docs?

We have a list of supported data sources with linked pages for individual tools, e.g., Postgres. You can find the source code in the same repo: https://github.com/cube-js/cube/tree/master/docs/pages/product/configuration

It would be great if you can add a page for Vertical as well.

You can use this as an icon: https://static.cube.dev/icons/vertica.svg

Hi - docs added. Cheers

[KSDaemon]

@timbrownls20 thnx for resolving linter issues! Could you please sync with the upstream? Cause This branch has conflicts that must be resolved. This should be pretty easy! Thnx!

[timbrownls20]

@timbrownls20 thnx for resolving linter issues! Could you please sync with the upstream? Cause This branch has conflicts that must be resolved. This should be pretty easy! Thnx!

No problem - conflicts resolved