Adjust client options to send credentials when needed #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paveltiunov
requested changes
Jul 3, 2020
| @@ -2,10 +2,11 @@ import fetch from 'cross-fetch'; | |||
| import 'url-search-params-polyfill'; | |||
|
|
|||
| class HttpTransport { | |||
| constructor({ authorization, apiUrl, headers = {} }) { | |||
| constructor({ authorization, apiUrl, headers = {}, credentials = 'same-origin' }) { | |||
There was a problem hiding this comment.
Let's leave default value to fetch itself and just remove 'same-origin'.
| @@ -25,10 +25,12 @@ class CubejsApi { | |||
| this.apiToken = apiToken; | |||
| this.apiUrl = options.apiUrl || API_URL; | |||
| this.headers = options.headers || {}; | |||
| this.credentials = options.credentials || 'same-origin'; | |||
added 2 commits
July 3, 2020 14:13
|
@colefichter Looks great! The only thing in index.d.ts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Note: the build instructions in the contribution guide are not working for me, so I can't build/run/test this change myself. Sorry about that!
Issue Reference this PR resolves
Original request here: #788
Description of Changes Made (if issue reference is not provided)
The Fetch API supports a credentials option to control the session cookies sent along with a request. By adjusting the Cube.js Client to support this option, we will be able to route our cube queries through a different sub-domain.
For example. If your site is running at secure.mydomain.com and your API calls need to go to api.mydomain.com it can be handy to pass the cookies over in the cross-domain API call. In order to support such a request pattern, the cube client must allow us to set credentials: 'include' when calling fetch().