Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rollup mode #843

Merged
merged 7 commits into from
Jul 16, 2020
Merged

feat: Rollup mode #843

merged 7 commits into from
Jul 16, 2020

Conversation

jcw-
Copy link
Contributor

@jcw- jcw- commented Jul 15, 2020

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

  • Adds support for only allowing queries to hit rollups.
  • Adds support for running a separate instance of cube.js to refresh rollups and set the api instance of cubejs to a mode where it doesn't try to check for rollups being current and doesn't try to create or refresh them.

@jcw-
Copy link
Contributor Author

jcw- commented Jul 15, 2020

@paveltiunov Thoughts? I'll put up a commit with documentation updates later (and fix the linting and tests), but I've tested this out and added error handling and ensured it's all opt-in functionality.

@jcw- jcw- marked this pull request as ready for review July 16, 2020 09:35
@paveltiunov
Copy link
Member

@jcw- Hey Jc! Looks great! Thanks for contributing it!

@paveltiunov paveltiunov merged commit cc41f97 into cube-js:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants