Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(cubesql): Attach cubenativeutils and cubesqlplanner to cargo fmt and cargo check #8677

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

Those are separate workspaces, with separate Cargo.lock, so we should at least check that lockfiles are up to date

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.65%. Comparing base (5fd13d1) to head (9041c11).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8677      +/-   ##
==========================================
- Coverage   82.66%   82.65%   -0.01%     
==========================================
  Files         221      221              
  Lines       78303    78303              
==========================================
- Hits        64726    64723       -3     
- Misses      13577    13580       +3     
Flag Coverage Δ
cubesql 82.65% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov force-pushed the more-workspaces-in-ci branch from 8433087 to 30d1318 Compare October 17, 2024 16:28
Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:39am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:39am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:39am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:39am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:39am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:39am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:39am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:39am

@mcheshkov mcheshkov force-pushed the more-workspaces-in-ci branch 4 times, most recently from e75c869 to 92f7495 Compare October 22, 2024 16:58
@mcheshkov mcheshkov force-pushed the more-workspaces-in-ci branch from 92f7495 to 9041c11 Compare November 13, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant