chore(cubesql): Do not call async Node functions while planning #8793
+137
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MazterQyou
force-pushed
the
cubesql/no-async-node-within-planning
branch
from
f7b05e7
to
5118b3d
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8793 +/- ##
==========================================
- Coverage 82.69% 82.68% -0.01%
==========================================
Files 221 221
Lines 78472 78474 +2
==========================================
- Hits 64890 64889 -1
- Misses 13582 13585 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MazterQyou
force-pushed
the
cubesql/no-async-node-within-planning
branch
from
5118b3d
to
81edfd1
Compare
MazterQyou
force-pushed
the
cubesql/no-async-node-within-planning
branch
from
81edfd1
to
23315a0
Compare
MazterQyou
force-pushed
the
cubesql/no-async-node-within-planning
branch
from
23315a0
to
d810695
Compare
paveltiunov
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
This PR restructures the way compiler cache works, removing the need to call async Node functions while planning, at the cost of passing around
compiler_id.