Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cubesql): Extract cube join condition check for rewrites to separate function #8835

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcheshkov
Copy link
Member

No description provided.

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:55am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:55am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:55am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:55am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:55am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:55am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:55am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 11:55am

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 98.70130% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.66%. Comparing base (5fd13d1) to head (4659f8c).

Files with missing lines Patch % Lines
...besql/cubesql/src/compile/rewrite/rules/members.rs 98.70% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8835   +/-   ##
=======================================
  Coverage   82.66%   82.66%           
=======================================
  Files         221      221           
  Lines       78303    78318   +15     
=======================================
+ Hits        64726    64742   +16     
+ Misses      13577    13576    -1     
Flag Coverage Δ
cubesql 82.66% <98.70%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov force-pushed the extract-cube-join-field-check branch from 4c845c8 to 476fe91 Compare October 21, 2024 13:46
@mcheshkov mcheshkov marked this pull request as ready for review October 21, 2024 16:31
@mcheshkov mcheshkov requested a review from a team as a code owner October 21, 2024 16:31
@mcheshkov mcheshkov force-pushed the extract-cube-join-field-check branch 2 times, most recently from 73e40f4 to 0ef06e4 Compare October 22, 2024 17:01
@mcheshkov mcheshkov force-pushed the extract-cube-join-field-check branch from 0ef06e4 to f3681ba Compare November 11, 2024 17:30
@mcheshkov mcheshkov force-pushed the extract-cube-join-field-check branch from f3681ba to 4659f8c Compare November 13, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant