fix(cubesql): Add checks that projection/filters/fetch in TableScan is empty #8883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8883 +/- ##
=======================================
Coverage 82.55% 82.55%
=======================================
Files 221 221
Lines 77709 77734 +25
=======================================
+ Hits 64151 64174 +23
- Misses 13558 13560 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mcheshkov
force-pushed
the
table-scan-rewrite-checks
branch
from
3ef4dc9
to
240947f
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
ptiurin
pushed a commit
to firebolt-db/cube
that referenced
this pull request
Nov 27, 2024
…s empty (cube-js#8883) Without these checks TableScan->CubeScan rule is, technically, unsound. For now it's just a sanity check, initial planning should not generate TableScan with any of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
Without these checks TableScan->CubeScan rule is, technically, unsound. For now it's just a sanity check.