Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-gateway): Meta - expose aliasMember for members in cube #8945

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

ovr
Copy link
Member

@ovr ovr commented Nov 12, 2024

Motivation:

While I was working on the new layer for MDX, I discovered that all members in views are defined as View's members. It leads to a problem, that I am not able to separate it by cubes to align our model with Analysis Services.

@ovr ovr requested a review from a team as a code owner November 12, 2024 10:27
@ovr ovr changed the title feat(api-gateway): Meta - expose aliasMember for members in view feat(api-gateway): Meta - expose aliasMember for members in cube Nov 12, 2024
Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 0:24am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 0:24am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 0:24am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 0:24am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 0:24am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 0:24am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 0:24am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 0:24am

@ovr ovr force-pushed the feat/schema-compiler-dimension-alias-member branch from 664cab5 to 07be00f Compare November 12, 2024 10:51
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM!

@ovr ovr requested review from a team as code owners November 12, 2024 12:20
@ovr ovr force-pushed the feat/schema-compiler-dimension-alias-member branch from edf69ce to 1a4c4bb Compare November 12, 2024 12:23
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.55%. Comparing base (218dcc2) to head (1a4c4bb).
Report is 29 commits behind head on master.

Files with missing lines Patch % Lines
...ql/cubeclient/src/models/v1_cube_meta_dimension.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8945      +/-   ##
==========================================
+ Coverage   82.50%   82.55%   +0.04%     
==========================================
  Files         221      221              
  Lines       77606    77713     +107     
==========================================
+ Hits        64027    64153     +126     
+ Misses      13579    13560      -19     
Flag Coverage Δ
cubesql 82.55% <92.85%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovr ovr merged commit c127f36 into master Nov 12, 2024
74 checks passed
@ovr ovr deleted the feat/schema-compiler-dimension-alias-member branch November 12, 2024 14:47
ptiurin pushed a commit to firebolt-db/cube that referenced this pull request Nov 27, 2024
…e-js#8945)

Motivation for change:

While working on the new layer for MDX, I discovered that all members in views are defined as View's members. This leads to a problem: I am not able to separate them by cubes to align our model with Analysis Services.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants