-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cubesql) Implement format / col_description #8947
base: master
Are you sure you want to change the base?
feat(cubesql) Implement format / col_description #8947
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
doesn't appear related to my changes, all specs i've added have passed 🤔 |
@pauldheinrichs My PR is also failing with the same set of tests. I was trying to find a PR for which this GHA was succeeding. |
I am not sure, but I prepared a potential fix for the CI issue: b75a37a @pauldheinrichs Could you please rebase your PR? Thanks! |
@ovr All set! Rebased! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8947 +/- ##
==========================================
- Coverage 82.66% 79.76% -2.90%
==========================================
Files 221 221
Lines 78303 78545 +242
==========================================
- Hits 64727 62654 -2073
- Misses 13576 15891 +2315
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@ovr Is there anything further you'd like to see in this PR? I'd love to merge this so we can update our metabase instance |
Semi-resolves: #8926
Hoping to unblock metabase failing field sync on it's latest version. This pull requests implements
format
macroIt also noops
schema
.table
identifiers)I don't have a tonne of bandwidth to fully implement the missing macro but this at least helps unblock the current request metabase is making to cube and failing when attempting to sync-fields.
It's not entirely clear if there's already an inherent way to lookup the table OID to get that result from the RegClass result to be leveraged in col_description implementation
Issue Reference this PR resolves
[For example #12]
Description of Changes Made (if issue reference is not provided)
[Description goes here]