feat: Add Dremio Cloud Support #8956
Open
+75
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
github-actions
bot
added
the
pr:community
KSDaemon
requested changes
Nov 28, 2024
There was a problem hiding this comment.
Hi @maladroitthief! Thanks for your contribution!
I left some comments how to make it cleaner and more aligned with the rest codebase.
|
And if you don't mind — please sync with the latest master (it would be easy, and no conflicts, but there are some updates related to ci) |
- Adds support to cubejs-dremio-driver for Dremio Cloud - Adds support for personal access tokens for Dremio Server
- Adds the dremioAuthToken config to support the dremio cloud driver
maladroitthief
force-pushed
the
dremio-cloud
branch
from
068560b
to
15e745e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
closes #8166
Description of Changes Made (if issue reference is not provided)