perf(cubestore): Arrow Cargo.lock pointers for GroupsAccumulator changes #8985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanges * Replaces Accumulator usage in grouped hash aggregation with GroupsAccumulator API * Makes all accumulators in DF grouped hash aggregation use GroupsAccumulatorFlatAdapter * Uses PrimitiveGroupsAccumulator and CountGroupsAccumulator for sum, min, max, and count for faster performance * Improves memory layout and traversal order of group by keys saved during grouped aggregation.
srh
force-pushed
the
groups-accumulator-pointer-update
branch
from
10d311d
to
89ce6b7
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
|
This now includes the 4th parameter change from #8994 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes test changes adding new sort_order information to expected pretty-print values, because of this (performance-related) bug fix: cube-js/arrow-datafusion@b3acc9f
Check List