feat(firebolt): Automatically start the engine after connection

[stepansergeevitch]

Check List

• Tests has been run in packages where changes made if available
• Linter has been run for changed code
• Tests for the changes have been added if not covered yet
• Docs have been added / updated if required

Issue Reference this PR resolves

We've received a support ticket that a customer cannot connect to a stopped engine

Description of Changes Made (if issue reference is not provided)

• Added engine autostart to ensure we can connect to a stopped engine
• Added a verbose user message when testing connection fails

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
examples-angular-dashboard	⬜️ Ignored (Inspect)	Visit Preview		Nov 27, 2024 1:12pm
examples-react-d3	⬜️ Ignored (Inspect)	Visit Preview		Nov 27, 2024 1:12pm
examples-react-dashboard	⬜️ Ignored (Inspect)	Visit Preview		Nov 27, 2024 1:12pm
examples-react-data-table	⬜️ Ignored (Inspect)	Visit Preview		Nov 27, 2024 1:12pm
examples-react-highcharts	⬜️ Ignored (Inspect)	Visit Preview		Nov 27, 2024 1:12pm
examples-react-material-ui	⬜️ Ignored (Inspect)	Visit Preview		Nov 27, 2024 1:12pm
examples-react-pivot-table	⬜️ Ignored (Inspect)	Visit Preview		Nov 27, 2024 1:12pm
examples-vue-query-builder	⬜️ Ignored (Inspect)	Visit Preview		Nov 27, 2024 1:12pm

[KSDaemon]

👍🏻 Great! Thanks for the contribution!

[KSDaemon]

@stepansergeevitch Do unit tests work for you? I tried the yarn run test and saw that they failed. I wonder if your newly added test works. %)

 FAIL  dist/test/autostart.test.js (7.08 s)
  ● FireboltDriver autostart › calls engine start

    TypeError: Cannot read properties of undefined (reading 'includes')

      85 |
      86 |     const username = getEnv('dbUser', { dataSource });
    > 87 |     const auth = username.includes('@')
         |                           ^
      88 |       ? { username, password: getEnv('dbPass', { dataSource }) }
      89 |       : { client_id: username, client_secret: getEnv('dbPass', { dataSource }) };
      90 |

      at new FireboltDriver (src/FireboltDriver.ts:87:27)
      at test/autostart.test.ts:15:14

[stepansergeevitch]

@stepansergeevitch Do unit tests work for you? I tried the yarn run test and saw that they failed. I wonder if your newly added test works. %)

 FAIL  dist/test/autostart.test.js (7.08 s)
  ● FireboltDriver autostart › calls engine start

    TypeError: Cannot read properties of undefined (reading 'includes')

      85 |
      86 |     const username = getEnv('dbUser', { dataSource });
    > 87 |     const auth = username.includes('@')
         |                           ^
      88 |       ? { username, password: getEnv('dbPass', { dataSource }) }
      89 |       : { client_id: username, client_secret: getEnv('dbPass', { dataSource }) };
      90 |

      at new FireboltDriver (src/FireboltDriver.ts:87:27)
      at test/autostart.test.ts:15:14

Hey @KSDaemon
This test actually requires you to set the env variables for the driver.
Specifiсally CUBEJS_DB_USER, CUBEJS_DB_PASS, CUBEJS_DB_NAME, CUBEJS_FIREBOLT_ACCOUNT and CUBEJS_FIREBOLT_ENGINE_NAME
So that it's able to connect to the database

[KSDaemon]

@stepansergeevitch Thnx for the notes! I see... So it's kind of impossible to setup isolated unit/integration tests. Anyway it requires cloud account/connection....

[KSDaemon]

@stepansergeevitch, Could you please add a console.log message at the beginning of the test suite saying that it is required to set up all those ENVs if some of the required ones are missing? This will help future contributors.