Add a safeguard to prevent infinite loop #59
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once I messed up group assignments and ended up in an infinite loop because the group assignment solver would not find a solution.
Have you encountered this issue before?
Here I'm not sure about the proper fix: I definitely want compscript to complain if groups are not feasible, but at the same time an infinite loop does not sound good.
For now I've simply added a break with a log, which may not be bothering enough (or let's say one could miss it), do you have a suggestion on how to return a proper error from this part of the code?