Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a safeguard to prevent infinite loop #59

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

viroulep
Copy link
Contributor

Once I messed up group assignments and ended up in an infinite loop because the group assignment solver would not find a solution.
Have you encountered this issue before?

Here I'm not sure about the proper fix: I definitely want compscript to complain if groups are not feasible, but at the same time an infinite loop does not sound good.
For now I've simply added a break with a log, which may not be bothering enough (or let's say one could miss it), do you have a suggestion on how to return a proper error from this part of the code?

@timreyn
Copy link
Collaborator

timreyn commented Mar 25, 2024

Yes, this has happened many times to me... :/

This is an improvement for now. When I start working on NAC groups I'll try to make this more resilient.

@timreyn timreyn merged commit 73535f1 into cubingusa:main Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants