build: add "enabled" option to nodes #685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is doable with the new comfyui functionalities introduced last week. it's not something that each node should take care of |
|
Can you please quickly refer to that change you mentioned please, couldn't
find it through comfy's changelog
…On Tue, Aug 20, 2024 at 13:22 Matteo Spinelli ***@***.***> wrote:
this is doable with the new comfyui functionalities introduced last week.
it's not something that each node should take care of
—
Reply to this email directly, view it on GitHub
<#685 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AS7RYS4S56TE7JLOIQXW3WDZSLHBPAVCNFSM6AAAAABMZAJJXKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJXHE4TAMJSGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
the stuff over here comfyanonymous/ComfyUI#2666 |
|
brilliant, many thx
…On Tue, Aug 20, 2024 at 15:01 Matteo Spinelli ***@***.***> wrote:
the stuff over here comfyanonymous/ComfyUI#2666
<comfyanonymous/ComfyUI#2666>
—
Reply to this email directly, view it on GitHub
<#685 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AS7RYSZ3PKB6ZYSIVKJTO5DZSLSTXAVCNFSM6AAAAABMZAJJXKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJYGEYTIMJZGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have added "enabled" input to both simple and advanced nodes to allow user toggle on and off. This is because in my usage scenario, I need to use 2 or more ipadapter nodes in the pipeline, but turning weight to 0 actually still affects the output. I have also tried the embedding way, but the same problem occurs. This toggle allows me to use the nodes more efficiently.