This repository has been archived by the owner on Mar 27, 2019. It is now read-only.
Stop vertical snap from creating pages past the scrollable range. #1134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
this pull request fixes an issue with the snap feature in vertically scrolled lists where you could increase the page counter past the scrollable range using next() or the mouse wheel.
I attached a demo page with a fairly minimal test case.
The setup is this:
Initially, the page count starts at 0. You can scroll 3 times until you reach the end of the list. The page count is now at 3 but subsequent clicks on "Next" will increase the page count up to 9 so that you would have to click "Prev" multiple times before the list actually scrolls up one element again.
Cheers
Daniel
Attachment: Demo page. Extract next to the other demos.
snap-max-scroll.zip