Skip to content
This repository has been archived by the owner on Mar 27, 2019. It is now read-only.

Multiple _animate bugfix #973

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

glebmachine
Copy link
Collaborator

Let me speak from my heart!

Very glad to made a pull request for iscroll)

This patch fixed annoying case:

iscroll.scrollTo(0,-500, 1000)
setTimeout(function(){
 iscroll.scrollTo(0,-2500, 1000) // this animation will ends on a half way, cause of first scroll make that.isAnimating was set to false and break all animations, created while first in progress.
}, 500)

@kaansoral
Copy link

Just inspected the code changes, looks great, I'm going to manually integrate this to my frankestein iscroll (too many manual modifications :)

@MichielDeMey
Copy link

+1 Nice to see a fix here! :)

@glebmachine
Copy link
Collaborator Author

glebmachine commented Oct 9, 2015 via email

@kaansoral
Copy link

I finally managed to test this on mobile devices too, iOS/Android - things seem much smoother now, thanks a lot for this improvement again

There was also rare crashes while scrolling, I think they might have been animations stacking, don't have enough experience to support this theory tho

@glebmachine
Copy link
Collaborator Author

up?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants