Fix supported characters in Tags #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilslv
changed the title
ilslv
changed the title
FCM |
ilslv
changed the title
tyranron
requested changes
Dec 8, 2021
src/parser.rs
Outdated
| @@ -415,7 +420,8 @@ rule scenario() -> Scenario | |||
| rule tag_char() -> &'input str | |||
| = s:$([_]) {? | |||
| let x = s.chars().next().unwrap(); | |||
| if x.is_alphanumeric() || x == '_' || x == '-' { | |||
| // `)` isn't allowed, as it would collide with TagExpression. | |||
| if !x.is_whitespace() && !"\r\n@)".contains(x) { | |||
There was a problem hiding this comment.
\r, \n and even \t are covered by .is_whitespace() already.
src/parser.rs
Outdated
| @@ -415,7 +420,8 @@ rule scenario() -> Scenario | |||
| rule tag_char() -> &'input str | |||
| = s:$([_]) {? | |||
| let x = s.chars().next().unwrap(); | |||
| if x.is_alphanumeric() || x == '_' || x == '-' { | |||
| // `)` isn't allowed, as it would collide with TagExpression. | |||
There was a problem hiding this comment.
As far as I see in reference implemetation, we should support it.
Maybe this should be resolved by escaping in TagExpression?
There was a problem hiding this comment.
@tyranron somewhere buried in separate github repo, there is mentioning of escaping https://github.com/cucumber/tag-expressions#escaping
tyranron
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves cucumber-rs/cucumber#174, cucumber-rs/cucumber#175
Synopsis
Despite nowhere to be documented, it looks like
.can be present inTags.Solution
Support any non-whitespace character, excluding
@and), as seen here.Checklist
Draft:prefixDraft:prefix is removed