Make sure a file/directory does not exist + Cleanup named file/directory steps

[ghost]

I often use an init-command to create some files. In my steps I try to make it obvious that the file should not exist. This PR adds new cucumber steps which makes the intent very clear and does not fail if I file/directory does not exist. This PR also includes a small refactoring - hope this is ok.

New steps

• Make sure file does not exist
• Make sure directory does not exist

Cleanup step

• Make directory step look the same like file step

I'm very well aware of the I remove file/directory "xz.txt"-step. But I think the intention is very different.

[ghost]

Mmh... Seems like there are some more inconsistencies in step names:

Then /^a file named "([^"]*)" should exist$/ do |file|
  check_file_presence([file], true)
end

Then /^a file named "([^"]*)" should not exist$/ do |file|
  check_file_presence([file], false)
end

Then /^the file "([^"]*)" should not exist$/ do |file_name|
  check_file_presence([file_name], false)
end

@jarl-dk What do you think which wording should be used? I don't think we should support both ones.

[mattwynne]

I don't think we should support both ones.

Actually, I'd love it if we did. I keep forgetting the 'named' bit when I use these steps in Cucumber's features, and I've always thought it read awkwardly. What about making it consistently optional?

[ghost]

I keep forgetting the 'named' bit when I use these steps in Cucumber's features,

Me too

What about making it consistently optional?

What do you mean with "consistently optional"?

[mattwynne]

Something like this:

Then /^a file(?: named)? "([^"]*)" should exist$/ do |file|
  check_file_presence([file], true)
end

[ghost]

ah. ok. I see. will fix that.

[ghost]

Ok. I changed some tests to test the new behaviour. Now all steps for directories/files are built like that. I also change the "not"-thing as well to reduce the number of needed steps - a pattern I found in other existing steps.

Then /^(?:a|the) file(?: named)? "([^"]*)" should (not )? exist$/ do |file, expect_match|
  check_file_presence([file], !expect_match)
end

[ghost]

If you prefer I can split up this PR and make a new one for the newly added steps. Although those steps were the reason I opened this PR. 😄

[ghost]

@mattwynne @jarl-dk

ok?

[mattwynne]

LGTM. It might be worth rebasing your commits to keep the history tidy when we merge this in.

[ghost]

Rebased.

[ghost]

@mattwynne @jarl-dk Can we go on with this PR?

[ghost]

Rebased.