Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename methods which run commands #438

Merged
merged 2 commits into from
Jun 29, 2017
Merged

Conversation

maxmeyer
Copy link
Member

@maxmeyer maxmeyer commented Jun 29, 2017

Summary

This PR changes the name of all methods running commands. Ping @cucumber/cucumber-ruby This will be on 1.0.0, so no breakage for now.

Details

run             -> run_command
run_simple -> run_command_and_stop

Motivation and Context

We had some issues with name clashes (e.g. #435) and personally I don't like #run_simple as method name as it hides some intent.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@maxmeyer maxmeyer merged commit 292ef4c into master Jun 29, 2017
@mvz mvz deleted the feature/rename-command-runners branch November 7, 2017 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant