-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove conditionals that will remain fixed once 1.0.0 is released #483
Conversation
I'll rebase this once #487 has been merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind to use "feature" branches in the "aruba" repo? This might make collaborating easier. I was not aware of https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/. Would you mind, if I push to your branches as well?
features/step_definitions/hooks.rb
Outdated
@@ -71,13 +71,7 @@ | |||
end | |||
|
|||
Before '@requires-aruba-version-1' do |scenario| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this all together here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@requires-aruba-version-1 @requires-aruba-version-1 aruba/features/03_testing_frameworks/cucumber/steps/command/check_output_of_command.feature
Line 388 in 51a034a
@requires-aruba-version-1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
@maxmeyer yes, pushing to my branches is fine. I'll update my remotes anyway so I push to the I'm not a big fan of using |
I rebased but canceled the build for now due to #492. |
@maxmeyer I made your requested changes and rebased again. Can you take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go.
Summary
Aruba contains many conditionals on Aruba::VERSION. With the pending release of 1.0.0, many of these will forever be true (or false, as the case may be). This PR removes these conditionals and any old code that will remain unused.
Motivation and Context
Part of cleaning up stuff for the 1.0.0 release.
Types of changes