Still Branch: Deprecated have_same_file_content_like and a_file_with_same_content_like matchers

[xtrasimplicity]

Summary

Deprecated have_same_file_content_like and a_file_with_same_content_like matchers, and added have_same_file_content_as and a_file_with_same_content_as matchers, onto the still branch.

This is a modified version of #555, applied to the still branch rather than master.

Details

Motivation and Context

To make it easier to understand what the matchers do.

How Has This Been Tested?

Added specs to ensure that the old and new matchers function correctly.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactoring (cleanup of codebase without changing any existing functionality)
• Update documentation

Checklist:

• I've added tests for my code
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[olleolleolle]

This is a helpful addition to the maintenance branch - users there will want to know.

[mvz]

Thanks, @xtrasimplicity. Would you mind re-opening #555 or opening a new PR for these changes to go in master, but with the deprecated methods removed?

[xtrasimplicity]

Thanks @mvz. I've just reopened the other PR, and will remove the deprecated methods when I get a chance.

[kinopyo]

Hi @xtrasimplicity, thanks for making the matcher easier to read and understand! I have one question regarding the difference between still branch and master.

I noticed in master branch, the cucumber/file is updated to use the new matcher in #555, but I don't see it in this PR and still branch. Is it by design or we missed it? 🙂

aruba/lib/aruba/cucumber/file.rb

Lines 175 to 181 in 3904a28

	Then(/^(?:a|the) file(?: named)? "([^"]*)" should (not )?be equal to file "([^"]*)"/) do |file, negated, reference_file|
	if negated
	expect(file).not_to have_same_file_content_like(reference_file)
	else
	expect(file).to have_same_file_content_like(reference_file)
	end
	end

cc @mvz @olleolleolle

Thanks in advance! 🙇

[mvz]

@kinopyo Yes, it would make sense to use the new names in still also. I guess we missed that 🙂.

[xtrasimplicity]

Hi @kinopyo,

Good catch on that one - it looks like I did indeed forget to update that. Would you be able to make a PR to patch this? If not, I'll jump onto this when I get a moment. :)

Thanks!

[kinopyo]

@mvz @xtrasimplicity Thanks for the quick response! Sure thing, will send a PR soon 😼! Happen to update the gem for an old project, the context is right there for me 😄

[mvz]

Happen to update the gem for an old project

Awesome. Please let me know of any problems you run into. Getting all projects to use 0.14.x is very important for the future of Aruba.