Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formally deprecate #use_clean_gemset #597

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Formally deprecate #use_clean_gemset #597

merged 1 commit into from
Feb 28, 2019

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Feb 27, 2019

Summary

Deprecate #use_clean_gemset in preparation for its removal in release 1.0.0

Details

Moves #use_clean_gemset to the Deprecated module, and makes it emit a warning when used.

Motivation and Context

Users of Aruba should be prepared for the removal of methods before they are actually removed.

How Has This Been Tested?

N/A.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (cleanup of codebase without changing any existing functionality)
  • Update documentation

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mvz mvz mentioned this pull request Feb 27, 2019
Closed
12 tasks
olleolleolle
olleolleolle approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A deprecation process helps operators and maintainers, as well as developers prepare for a future.

@mvz mvz merged commit 6d0c79a into still Feb 28, 2019
@mvz mvz deleted the deprecate-use_clean_gemspec branch February 28, 2019 09:22
@mvz
Copy link
Contributor Author

mvz commented Apr 28, 2019

Note: this is part of #598.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
status: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvz @olleolleolle