Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen childprocess dependency #658

Merged
merged 2 commits into from
Jul 16, 2019
Merged

Loosen childprocess dependency #658

merged 2 commits into from
Jul 16, 2019

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Jul 12, 2019

Summary

Allow end-users to use childproces 2.0.0 on recent Rubies

Details

  • Loosen dependency on childprocess.
  • Adjust Gemfile to allow childprocess 2.0.0 on recent Rubies.

Motivation and Context

Allows users to stay up-to-date.

How Has This Been Tested?

Tests are run with new version 2.0.0 of childprocess on Travis CI for compatible Ruby versions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (cleanup of codebase without changing any existing functionality)
  • Update documentation

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

luke-hill
luke-hill approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@luke-hill luke-hill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit

@mvz mvz merged commit ada4dde into still Jul 16, 2019
@mvz mvz deleted the loosen-childprocess-dependency-still branch July 16, 2019 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luke-hill luke-hill luke-hill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvz @luke-hill