Refactor/remove cop patching #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general, I'm all for moving all TODO items to However, due to the interaction of the LineLength cop with IfUnlessModifier we should keep LineLength at 150. Perhaps once #693 is done that does not matter that much anymore. |
|
I'll fix that up in here once 693 is merged |
… and also probably not used - Will need more investigation # Conflicts: # .rubocop_todo.yml
mvz
force-pushed
the
refactor/remove_cop_patching
branch
from
e121c54 to
3742815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Give us a base to work out what exactly needs fixing in one file and have a single source of truth
Details
Remove inline cop patching as it's a bit tricky to triage and work out what conflicts with what.
Motivation and Context
Allows us to refactor stuff down the line better
How Has This Been Tested?
Rubocop CI should still pass.
Screenshots (if appropriate):
Types of changes
Checklist: