Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RuboCop and correct new offenses #711

Merged
merged 3 commits into from
May 17, 2020
Merged

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Apr 17, 2020

Summary

Update to RuboCop 0.82 and autocorrect new offenses

Details

  • Update RuboCop dependency to 0.82
  • Enable new cops from RuboCop 0.80-0.82
  • Autocorrect new offenses

Motivation and Context

Keeps stuff up-to-date.

How Has This Been Tested?

I ran RuboCop.

Types of changes

  • Refactoring (cleanup of codebase without changing any existing functionality)

@mvz mvz force-pushed the update-rubocop-dependency branch from a0e9069 to ea25f4e Compare April 17, 2020 06:05
@@ -550,7 +550,7 @@ def actual_permissions
expect(full_content).to match(/zoo/)
expect(full_content).not_to match(/foo/)
end
end . to raise_error RSpec::Expectations::ExpectationNotMetError
end.to raise_error RSpec::Expectations::ExpectationNotMetError
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much nicer.

@mvz mvz merged commit 3b78325 into master May 17, 2020
@mvz mvz deleted the update-rubocop-dependency branch May 17, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants