Use manifest file to specify set of files to include in gem #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids unexpected RuboCop failures.
aruba.gemspec
Outdated
| spec.add_development_dependency 'simplecov', '~> 0.18.0' | ||
| spec.add_development_dependency 'yard-junk', '~> 0.0.7' | ||
|
|
||
| spec.rubygems_version = '>= 1.6.1' | ||
| spec.required_ruby_version = '>= 2.4' | ||
|
|
||
| spec.files = Rake::FileList['{docs,fixtures,lib}/**/*', 'CHANGELOG.md', \ | ||
| 'LICENSE', 'README.md'].exclude(*File.read('.gitignore').split) | ||
| spec.files = File.read('Manifest.txt').split |
There was a problem hiding this comment.
Curious: can this use https://rubyapi.org/2.7/o/io#method-c-readlines ? With chomp: true I guess.
There was a problem hiding this comment.
Yes! I didn't know about chomp: true; much nicer!
mvz
changed the title
Travis adds --client to JRUBY_OPTS which causes a warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stop dynamically collecting files to include in the gem and instead specify (most of) them in a manifest file
Details
Use rake-manifest gem to generate and check a
Manifest.txtfile, and read that file in the gemspec to set the list of files to include in the gem. Also, run manifest checking task before gem building task.Motivation and Context
git ls-filesin gemspec #721)git ls-filesin gemspec #721 does not accurately exclude filesgit ls-filesin gemspec #721 needs parts of rake that may not be installed when e.g. Bundler is run to install dependencies, so just runningbundle installto fetch dependencies from a fresh checkout doesn't work, leading to build failures on TravisCIHow Has This Been Tested?
Types of changes