Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #727

Merged
merged 3 commits into from
Aug 21, 2020
Merged

Update dependencies #727

merged 3 commits into from
Aug 21, 2020

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Aug 21, 2020

Summary

Update dependencies to allow their latest versions

Details

  • Allow cucumber 5
  • Update simplecov development dependency

Motivation and Context

Aruba should support testing with latest Cucumber

How Has This Been Tested?

Travis will check that installation proceeds correctly on all supported Ruby versions, in particular on 2.4, which is not supported by Cucumber 5.

Types of changes

  • New feature (non-breaking change which adds functionality)

@mvz mvz force-pushed the update-dependencies branch from 16ad378 to 77a16e6 Compare August 21, 2020 14:10
@mvz
Copy link
Contributor Author

mvz commented Aug 21, 2020

Tests are failing, it seems due to a subtle difference in the output of diffs between diff-lcs 1.3 and 1.4.

@mvz
Copy link
Contributor Author

mvz commented Aug 21, 2020

See rspec/rspec-support#421 for more details on the diff changes due to diff-lcs. Looks like we'll need to loosen the expectations so both behaviors will be considered fine.

This keeps the 'Diff:' part to indicate that some kind of diff should be
output, but doesn't dictate the format of the diff, since that detail is
not really important for this scenario.
@mvz mvz added this to the 1.1.0 milestone Aug 21, 2020
@mvz mvz merged commit 32420eb into master Aug 21, 2020
@mvz mvz deleted the update-dependencies branch August 21, 2020 18:00
@mvz mvz removed this from the 1.1.0 milestone Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant