Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze string literals by default #929

Merged
merged 4 commits into from
May 31, 2024
Merged

Freeze string literals by default #929

merged 4 commits into from
May 31, 2024

Conversation

mvz
Copy link
Contributor

@mvz mvz commented May 31, 2024

Summary

Add # frozen_string_literal: true comments to all files and fix what breaks.

Details

  • Re-enable Style/FrozenStringLiteralComment cop
  • Autocorrect Style/FrozenStringLiteralComment offenses
  • Make CommandMonitor output collection methods work with frozen string literals
  • Restore spec for unfrozen input to command

Motivation and Context

Ruby 3.4 will freeze string literals by default.

How Has This Been Tested?

I ran specs and cukes.

Types of changes

  • Internal change (refactoring, test improvements, developer experience or update of dependencies)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mvz mvz merged commit 62e788a into main May 31, 2024
18 checks passed
@mvz mvz deleted the freeze-string-literals branch May 31, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant