[Ruby]: Optimise KeysChecker#compare #51

luke-hill · 2023-10-05T11:58:27Z

Optimise #compare and reduce complexity. Fixes #42

🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

I agree to respect and uphold the Cucumber Community Code of Conduct
I've changed the behaviour of the code
- I have added/updated tests to cover my changes.
My change requires a change to the documentation.
- I have updated the documentation accordingly.
Users should know about my change
- I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

… of responsibilities

…any instead of not none

luke-hill added 11 commits October 5, 2023 11:36

Remove unrequired wrapper call

11e0735

Slightly optimise class into standard structure to allow splitting up…

9d26076

… of responsibilities

Cache and optimise the checking for identical keys

534ce03

Isolate rejection logic

0e6f8fe

Rename found to detected to infer this is actually detected

d3ac897

Use method for class name to reduce complexity of #compare

6fbdab0

Tidy up comparator spec

bded02c

Minor linting of specs

a2fa521

Further DRY up of #compare private methods

558b7bb

Move out classification of extra/missing keys and check if there are …

8771237

…any instead of not none

Add changelog

95fa4f2

luke-hill merged commit 075a23f into main Oct 5, 2023
7 checks passed

luke-hill deleted the refactor/42-optimise-keyschecker branch October 5, 2023 12:07

Provide feedback