pickle_filter: use absolute paths

[mmuller99]

resolves #924

[charlierudolph]

Does a test fail if the || '' is removed? I don't understand why that is needed

[mmuller99]

resolve requires a string argument, could rewrite as:

const lines = this.featureUriToLinesMapping[uri ? path.resolve(uri) : undefined]

or just return true if uri is undefined, which is the case when running with a line that does not exist

[charlierudolph]

I can't think of a case where this function would be called without a uri though.

[mmuller99]

uri is undefined during all of the line, name, and tag filters tests

[charlierudolph]

Auhh. Can you please update the unit tests so a uri is always passed in? I'd prefer not to have the || '' since in real use I expect the uri to always be there

[mmuller99]

tests were setting uri to:

this.input.uri = this.scenarioPath

where this.scenarioPath was undefined

[aslakhellesoy]

Hi @mmuller99,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
• 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

[charlierudolph]

Thanks! I'll release this later today

[mmuller99]

@charlierudolph, @aslakhellesoy thanks

[gd46]

Thanks guys for getting this fix!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.