[JUnit Platform] Warn if feature files could not be found #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
force-pushed
the
junit-platform-warn-if-no-features
branch
from
3e2bea9 to
c530be2
Compare
mpkorstanje
changed the title
Both Surefire and Gradle assume that tests are contained within a class and use `ClassSelector` to discover tests in these classes. Cucumber uses plain text files. By using a class annotated with `@Cucumber` we work around this behaviour. Cucumber will then scan the package and sub-packages of the annotated class for feature files. When using this system, in case of misconfiguration it is not immediately clear if the test engine is not picked up or if the location of the feature files and annotated class do not line up. While we can not generically log a warning in case a discovery selector did not find any features, we can log a warning in this special case. It is clear that the intend was to put feature files in the package. Otherwise the annotated class could/should be removed to suppress this warning. Fixes: #2179
mpkorstanje
force-pushed
the
junit-platform-warn-if-no-features
branch
from
c530be2 to
a3dcc4c
Compare
Codecov Report
@@ Coverage Diff @@
## main #2182 +/- ##
============================================
+ Coverage 82.79% 82.80% +0.01%
- Complexity 2324 2328 +4
============================================
Files 306 306
Lines 8294 8300 +6
Branches 762 763 +1
============================================
+ Hits 6867 6873 +6
Misses 1118 1118
Partials 309 309
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Surefire and Gradle assume that tests are contained within a class and
use
ClassSelectorto discover tests in these classes. Cucumber uses plaintext files. By using a class annotated with
@Cucumberwe work around thisbehaviour. Cucumber will then scan the package and sub-packages of the
annotated class for feature files.
When using this system, in case of misconfiguration it is not immediately clear
if the test engine is not picked up or if the location of the feature files and
annotated class do not line up.
While we can not generically log a warning in case a discovery selector did not
find any features, we can log a warning in this special case. It is clear that
the intend was to put feature files in the package. Otherwise the annotated
class could/should be removed to suppress this warning.
Fixes: #2179