Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with PrettyFormatter printing URL encoded strings #2545

Merged
merged 1 commit into from
May 2, 2022

Conversation

skloessel
Copy link
Contributor

  • Added a test case (should_print_encoded_characters) that prints URL encoded characters to the scenario in the form of a table .
  • Adjusting of PrettyFormater .. instead of using String.format(..) - just appending
    1. the scenario indentation
    2. the line to be printed
    3. systems line-separator
      .. to the StringBuilder.

Fixes issues 2544

…d output.

- Added a test case (should_print_encoded_characters) that prints URL encoded characters to the scenario in the form of a table .
- Adjusting of PrettyFormater .. instead of using String.format(..) - just appending
	1. the scenario indentation
	2. the line to be printed
	3. systems line-separator
.. to the StringBuilder.
@mpkorstanje mpkorstanje changed the title Fixes issues 2544 - problems with PrettyFormatter printing URL encode… Fixe problem with PrettyFormatter printing URL encoded strings May 2, 2022
@mpkorstanje mpkorstanje changed the title Fixe problem with PrettyFormatter printing URL encoded strings Fix problem with PrettyFormatter printing URL encoded strings May 2, 2022
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #2545 (0220cfb) into main (606fa07) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #2545   +/-   ##
=========================================
  Coverage     84.50%   84.50%           
  Complexity     2655     2655           
=========================================
  Files           310      310           
  Lines          9337     9339    +2     
  Branches        898      898           
=========================================
+ Hits           7890     7892    +2     
  Misses         1115     1115           
  Partials        332      332           
Impacted Files Coverage Δ
.../java/io/cucumber/core/plugin/PrettyFormatter.java 85.51% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 606fa07...0220cfb. Read the comment docs.

@mpkorstanje mpkorstanje merged commit 98b5a7c into cucumber:main May 2, 2022
@aslakhellesoy
Copy link
Contributor

Hi @skloessel,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@mpkorstanje
Copy link
Contributor

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants