Merge pull request #530 from cucumber/prep_for_release_2_5

Prep for release 2 5
cucumber · Feb 21, 2022 · 9d8f2e6 · 9d8f2e6
2 parents 4919c18 + 969ccc3
commit 9d8f2e6
Showing 1 changed file with 16 additions and 11 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -10,30 +10,35 @@ jobs:
         ruby: [ '2.5.8', '2.6', '2.7', '3.0', '3.1' ]
         gemfile: [ 'rails_5_0', 'rails_5_1', 'rails_5_2', 'rails_6_0', 'rails_6_1', 'rails_7_0' ]
         exclude:
-          # Only test latest Rails (Of each major), on actively supported Ruby Versions
-          # Only test latest Ruby with latest Rails versions (Of each major)
-          # 2.5  -> Not 5.2/6.1
-          # 2.6  -> Users of this should be using Rails 5.2+
-          # 2.7  -> Users of this should be using Rails 5.2+
-          # 3.0  -> Rails 6.1 and 7.0
-          # 3.1  -> Only 7.0
+          # Newest ruby will test
+          # - all permissible rails versions in current major
+          # - latest rails version in the last major
+          # Supported rubies will test
+          # - all permissible rails versions in current major
+          # - all permissible supported rails versions beneath latest major
+          # Unsupported rubies will test
+          # - all permissible rails versions released within 6 months of EOL
+          # - not the latest rails version
+
+          # 2.5 -> Unsupported from March '21 -> Only test up to Sep '21
+          # 2.6 -> Unsupported from March '22 -> Only test up to Sep '22
+          # 2.7 -> Supported until March '23 (At least)
+          # 3.0 -> Supported for a while...
           - { ruby: '2.5.8', gemfile: 'rails_5_2' }
+          - { ruby: '2.5.8', gemfile: 'rails_6_0' }
           - { ruby: '2.5.8', gemfile: 'rails_6_1' }
           - { ruby: '2.5.8', gemfile: 'rails_7_0' }
-          - { ruby: '2.6', gemfile: 'rails_5_0' }
-          - { ruby: '2.6', gemfile: 'rails_5_1' }
           - { ruby: '2.6', gemfile: 'rails_7_0' }
           - { ruby: '2.7', gemfile: 'rails_5_0' }
           - { ruby: '2.7', gemfile: 'rails_5_1' }
           - { ruby: '3.0', gemfile: 'rails_5_0' }
           - { ruby: '3.0', gemfile: 'rails_5_1' }
-          - { ruby: '3.0', gemfile: 'rails_5_2' }
+          - { ruby: '3.0', gemfile: 'rails_5_2' } # Rails 5.2 won't work with Ruby 3+: https://github.com/rails/rails/issues/40938
           - { ruby: '3.0', gemfile: 'rails_6_0' }
           - { ruby: '3.1', gemfile: 'rails_5_0' }
           - { ruby: '3.1', gemfile: 'rails_5_1' }
           - { ruby: '3.1', gemfile: 'rails_5_2' }
           - { ruby: '3.1', gemfile: 'rails_6_0' }
-          - { ruby: '3.1', gemfile: 'rails_6_1' }
     env:
       BUNDLE_GEMFILE: gemfiles/${{ matrix.gemfile }}.gemfile
     steps: