Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workflows #549

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Update workflows #549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,17 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [ '2.5.8', '2.6', '2.7', '3.0', '3.1' ]
gemfile: [ 'rails_5_0', 'rails_5_1', 'rails_5_2', 'rails_6_0', 'rails_6_1', 'rails_7_0' ]
ruby: ['2.5.8', '2.6', '2.7', '3.0', '3.1']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: How would you feel about using YAML lists, like

- '2.5.8'
- '2.6'
- '2.7'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess we could. I think this was just the way that GHA was advertised. Everyone I know does it this way.

gemfile: ['rails_5_0', 'rails_5_1', 'rails_5_2', 'rails_6_0', 'rails_6_1', 'rails_7_0']
exclude:
# Newest ruby will test
# - all permissible rails versions in current major
# - latest rails version in the last major
# Latest ruby will test
# - all rails versions in current major
# - latest rails version in the previous major
# Supported rubies will test
# - all permissible rails versions in current major
# - all permissible supported rails versions beneath latest major
# - all permissible supported rails versions
# Unsupported rubies will test
# - all permissible rails versions released within 6 months of EOL
# - not the latest rails version
# - nothing in the current rails major

# 2.5 -> Unsupported from March '21 -> Only test up to Sep '21
# 2.6 -> Unsupported from March '22 -> Only test up to Sep '22
Expand All @@ -34,7 +33,6 @@ jobs:
- { ruby: '3.0', gemfile: 'rails_5_0' }
- { ruby: '3.0', gemfile: 'rails_5_1' }
- { ruby: '3.0', gemfile: 'rails_5_2' } # Rails 5.2 won't work with Ruby 3+: https://github.com/rails/rails/issues/40938
- { ruby: '3.0', gemfile: 'rails_6_0' }
- { ruby: '3.1', gemfile: 'rails_5_0' }
- { ruby: '3.1', gemfile: 'rails_5_1' }
- { ruby: '3.1', gemfile: 'rails_5_2' }
Expand All @@ -52,7 +50,6 @@ jobs:
- run: bundle exec rubocop
# ruby-2.5.8 and 2.5.9 has issues running bundle install during specs.
# see errors here https://github.com/mgrunberg/cucumber-rails/runs/4824503004?check_suite_focus=true
# seems incompatibility with psych gem and rubygems version.
- run: gem update --system
if: matrix.ruby == '2.5.8'
- run: bundle exec rake cucumber