Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rails 7.1 #575

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Support rails 7.1 #575

merged 4 commits into from
Oct 12, 2023

Conversation

mgrunberg
Copy link
Contributor

🤔 What's changed?

Use symbols to set show_exceptions in Rails 7.1+ and run test against Rails 7.1

⚡️ What's your motivation?

I get a deprecation warning about the usage of a boolean with show_exceptions

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Removes
```
DEPRECATION WARNING: Setting action_dispatch.show_exceptions to false is deprecated. Set to :none instead. (called from call at /home/runner/work/cucumber-rails/cucumber-rails/lib/cucumber/rails/action_dispatch.rb:14)
```
Rails 7.1 introduces a new "Raise error on missing only unless" feature
(see rails/rails#43487).

The new feature is enabled by default. I rewrote the
auto-generated code in feature specs to comply to the new rule.
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are carefully-worded, nice changes!

@olleolleolle olleolleolle merged commit 1cf4099 into cucumber:main Oct 12, 2023
14 checks passed
@mgrunberg mgrunberg deleted the add-rails-7.1 branch October 12, 2023 15:16
@luke-hill
Copy link
Contributor

Can we add a changelog entry for this please as it's quite a big change @mgrunberg

@mgrunberg
Copy link
Contributor Author

@luke-hill is #578 enough? I can change the message content if not.

Also, would you consider releasing 3.0.0.rc.2?

@luke-hill
Copy link
Contributor

I'm looking to release v3 proper soon. We got about 1/2 to 2/3rds of the stuff in the rc1 release. There was only 2 big things I wanted to do else. One is on a branch I asked a couple of people to look at.

Also I want to try leave the rc1 out for a bit to ensure nothing is completely goosed there.

@mgrunberg
Copy link
Contributor Author

@luke-hill is now a good time for 3.0.0.rc.2?
About a proper v3 release, you mention two big things pending. Let me know how I can help with those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants