Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outsource event bus #933

Merged
merged 1 commit into from Jan 8, 2016
Merged

Outsource event bus #933

merged 1 commit into from Jan 8, 2016

Conversation

ghost
Copy link

@ghost ghost commented Nov 13, 2015

@mattwynne This PR outsources the whole event bus thing in a separate library but brings the same functionality like #932: Either #932 or this PR should be merged

If this is merged: @aslakhellesoy @mattwynne can you send me your email-addresses so I can make you owner of the event-bus-gem too? I would also prefer to move the library's repository to the cucumber organization to give some more people admin access to it. WDYT

@ghost ghost mentioned this pull request Nov 13, 2015
@mattwynne
Copy link
Member

Thanks again @dg-ratiodata I will review soonish.

I agree in principle that the event-bus is something that we could factor out, I'm just a little bit dubious about whether it's worth it for 100 LOC.

@tooky and I paired on this code so he should be involved as a maintainer of any future gem too.

@ghost
Copy link
Author

ghost commented Nov 16, 2015

I agree in principle that the event-bus is something that we could factor out, I'm just a little bit dubious about whether it's worth it for 100 LOC.

I agree, but:

  • No C&P of the same code between aruba and cucumber
  • Better documentation, btw. Aruba + Cucumber -> Living Documentation
  • Better tests
  • Versioninig of API

@ghost
Copy link
Author

ghost commented Nov 16, 2015

@tooky and I paired on this code so he should be involved as a maintainer of any future gem too.

Yeah. No problem. :-) @tooky Can you send me your e-mail address as well. If you like via PM on Twitter.

@ghost
Copy link
Author

ghost commented Nov 26, 2015

@mattwynne The code in event-bus has now a slightly different, but backward compatible API. You can now register multiple events (Array) at once for the same handler. That's something I needed for aruba to DRY up code.

@ghost
Copy link
Author

ghost commented Nov 26, 2015

I forgot to add this one: https://github.com/dg-ratiodata/event-bus.

@ghost
Copy link
Author

ghost commented Nov 26, 2015

aruba now uses event-bus I finally merged the code into master. :-) cucumber/aruba#309

@mattwynne mattwynne merged commit 95d2e6c into cucumber:master Jan 8, 2016
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant