Skip to content
This repository has been archived by the owner on Dec 21, 2024. It is now read-only.

Language tabs should be URL-aware #637

Open
mattwynne opened this issue Jun 23, 2021 · 5 comments
Open

Language tabs should be URL-aware #637

mattwynne opened this issue Jun 23, 2021 · 5 comments
Assignees

Comments

@mattwynne
Copy link
Member

I want to link someone to the Ruby version of https://cucumber.io/docs/cucumber/state/ but the URL doesn't change when I switch language tabs.

I'd like the language tabs to:

  1. Switch to the appropriate language tab on opening a page if a querystring parameter is present (e.g. ?lang=ruby)
  2. Update the URL if the language tab is changed (could be dynamic or by just hyperlinking to the new URL)

How would we achieve this?

@10xtechie
Copy link
Member

@mattwynne, @aurelien-reeves
I would like to take this on. So if it is still relevant, please assign this to me :)

@mattwynne
Copy link
Member Author

mattwynne commented Jun 22, 2022

Yay! thanks @10xtechie yes it's absolutely still relevant!

https://calendly.com/mattwynne if you want to pair.

@mattwynne
Copy link
Member Author

@10xtechie
Copy link
Member

@mattwynne @aurelien-reeves ,
Thanks for assigning this to me! I have created a PR, please take a look.

@10xtechie
Copy link
Member

I think the code for the tabs is here: https://github.com/cucumber/docs/blob/main/themes/cucumber-sb/static/js/site.js

@mattwynne ,
You are right, thanks!

10xtechie added a commit to 10xtechie/docs that referenced this issue Jun 24, 2022
10xtechie added a commit to 10xtechie/docs that referenced this issue Jun 24, 2022
mattwynne added a commit that referenced this issue Jun 30, 2022
10xtechie added a commit to 10xtechie/docs that referenced this issue Jun 30, 2022
10xtechie added a commit to 10xtechie/docs that referenced this issue Jun 30, 2022
10xtechie added a commit to 10xtechie/docs that referenced this issue Jul 1, 2022
10xtechie added a commit to 10xtechie/docs that referenced this issue Jul 12, 2022
…nd seeting language to url query parameter while selecting default, selected, and local storage language
mattwynne added a commit that referenced this issue Jul 12, 2022
issue #637 - addressing a PR comment for tidying up code
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants