Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] Refactor/gherkin autofix cops #266

Merged
merged 38 commits into from
Sep 16, 2024
Merged

Conversation

luke-hill
Copy link
Contributor

🤔 What's changed?

Initial pass at fixing low hanging fruit / prep for larger refactor - ~10% fixed

⚡️ What's your motivation?

Begin to tidy up codebase and become familiar in preparation for a large chunk of PR's to tidy up Ruby Gherkin

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@luke-hill
Copy link
Contributor Author

@gasparnagy - I might need your help or someone elses help here to explain how this CI process works.

I am fairly certain I know where the issues have come from (Me doing tidying in the wrong way), but would be good to have a catch up to work out how I can do "some" of these fixes that are nearly a decade in the needing.

@luke-hill luke-hill merged commit 72c973b into main Sep 16, 2024
6 checks passed
@luke-hill luke-hill deleted the refactor/gherkin_autofix_cops branch September 16, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants