Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] Refactor/rubocop bump #369

Merged
merged 16 commits into from
Feb 10, 2025
Merged

[Ruby] Refactor/rubocop bump #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e6d19af
Update rubocop by introducing all other sub-gems
luke-hill Feb 5, 2025
09dffed
Regen the TODO file for new gem introduction
luke-hill Feb 5, 2025
47ccd11
Add entry in rubocop issue tracker for problem;
luke-hill Feb 5, 2025
bfb0019
Regenerate TODO with a downgraded version of rubocop and introduced s…
luke-hill Feb 6, 2025
ad15b75
Reintroduce local override for MethodName whilst bug is still prevalent
luke-hill Feb 6, 2025
f9ccd7e
Partial interim update of rubocop subgems to try alleviate deprecatio…
luke-hill Feb 6, 2025
23f8b16
Update rubocop gems to all latest
luke-hill Feb 6, 2025
04a4028
Final TODO regeneration - added a few more ignores whilst gems are be…
luke-hill Feb 6, 2025
8414e4d
Add changelog for this change and the next PR
luke-hill Feb 6, 2025
64becec
Merge branch 'main' into refactor/rubocop_bump
luke-hill Feb 8, 2025
8353610
Fix up ruby 3.2 cop offenses
luke-hill Feb 8, 2025
d645af6
Fix up some spacing autofix cops and add note about fix for heredoc r…
luke-hill Feb 8, 2025
bab61de
AF: Layout/SpaceAfterComma
luke-hill Feb 8, 2025
239c4fb
Fix up RSpec context
luke-hill Feb 8, 2025
c7a76bd
Fix up a couple of minor autofixes for the razor template that genera…
luke-hill Feb 8, 2025
5e43588
Manually fix one of the parser issues
luke-hill Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
### Changed
- [.NET] Reduce NuGet size by only targeting .NET Standard 2.0
- [.NET] Changed some types from class to struct, removed IGherkinLine interface and changes some functions from Array to Enumerable
- [Ruby] Update minimum ruby requirement from 3.0 to 3.2
- [Ruby] Introduce rubocop subgems to facilitate optimisations
- [JavaScript] BREAKING CHANGE: Update supported Node.js versions to 18, 20, 22 and 23 ([#365](https://github.com/cucumber/gherkin/pull/365))

### Fixed
Expand Down
18 changes: 8 additions & 10 deletions ruby/.rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,11 @@ inherit_mode:
merge:
- Exclude

#require:
# - rubocop-packaging
# - rubocop-performance
# - rubocop-rails
# - rubocop-rake
# - rubocop-rspec
require:
- rubocop-packaging
- rubocop-performance
- rubocop-rake
- rubocop-rspec

AllCops:
TargetRubyVersion: 3.2
Expand All @@ -33,10 +32,9 @@ Style/RegexpLiteral:
EnforcedStyle: slashes
AllowInnerSlashes: true

## Disabled until rubocop-rspec is introduced
#RSpec/MessageSpies:
# EnforcedStyle: receive
RSpec/MessageSpies:
EnforcedStyle: receive

# Hack to make rubocop not flag these (We need to re-analyse these later on)
# Bug in rubocop auto-gen config: https://github.com/rubocop/rubocop/issues/13795
Naming/MethodName:
Enabled: false
Loading
Loading