Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go version in go.mod (go1.16). Update dependencies #471

Merged
merged 4 commits into from
Apr 28, 2022

Conversation

mdeolmosmeli
Copy link
Contributor

@mdeolmosmeli mdeolmosmeli commented Apr 20, 2022

🤔 What's changed?

Fix go version in go mod and update dependencies.

⚡️ What's your motivation?

Stop using old dependencies. There are some old version that are being included in the packege.
E.g.: viper v1.7.0 and all its dependencies.

There are some old dependencies in the code. Updating them, I found that go version is 1.13 in go mod. 👉 (Here)

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@1a795f1). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage        ?   81.42%           
=======================================
  Files           ?       27           
  Lines           ?     2197           
  Branches        ?        0           
=======================================
  Hits            ?     1789           
  Misses          ?      312           
  Partials        ?       96           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a795f1...d43a499. Read the comment docs.

@mdeolmosmeli
Copy link
Contributor Author

mdeolmosmeli commented Apr 22, 2022

@mattwynne Sorry. It's me again :). Could you please trigger the job again?

@mattwynne
Copy link
Member

Looks good @mdeolmosmeli

Copy link
Member

@vearutop vearutop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vearutop vearutop merged commit 4ca5ec0 into cucumber:main Apr 28, 2022
@aslakhellesoy
Copy link
Contributor

Hi @mdeolmosmeli,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@RodolfoS-ML
Copy link

Hi @vearutop 'n @aslakhellesoy, do you have any schedule for the releases?

@vearutop
Copy link
Member

Not exactly, but I think we can release a v0.12.6 soon to make recent changes more accessible.

@mattwynne
Copy link
Member

@RodolfoS-ML we never make any commitments to dates for releases. Life is too unpredictable for that! Also, most of the contributors to the cucumber org's code are volunteers, so people need to be able to work on things at their own pace.

@vearutop we could make use of Github's Milestones feature to help communicate the scope of upcoming releases, if not the schedule. Might also help with planning a 1.0.0 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants