Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI for go1.20 #552

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Update CI for go1.20 #552

merged 1 commit into from
Apr 3, 2023

Conversation

vearutop
Copy link
Member

@vearutop vearutop commented Mar 29, 2023

🤔 What's changed?

This PR updates CI jobs to use latest version of Go and changes tests to accommodate for golang/go#51774.

Resolves #551.

⚡️ What's your motivation?

It has been a while since we've bumped version of Go in CI mostly due to a breaking change in runtime.FuncForPC file/line resolution introduced in go1.18.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

Nothing here.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@github-actions
Copy link

Go API Changes

# github.com/cucumber/godog
## compatible changes
(*ScenarioContext).Given: added
(*ScenarioContext).Then: added
(*ScenarioContext).When: added

# github.com/cucumber/godog/formatters
## compatible changes
Given: added
Keyword: added
None: added
StepDefinition.Keyword: added
Then: added
When: added

# summary
Inferred base version: v0.12.6
Suggested version: v0.13.0

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #552 (1ac90aa) into main (dc8c9c4) will not change coverage.
The diff coverage is n/a.

❗ Current head 1ac90aa differs from pull request most recent head c92c4c2. Consider uploading reports for the commit c92c4c2 to get more accurate results

@@           Coverage Diff           @@
##             main     #552   +/-   ##
=======================================
  Coverage   82.94%   82.94%           
=======================================
  Files          28       28           
  Lines        3371     3371           
=======================================
  Hits         2796     2796           
  Misses        461      461           
  Partials      114      114           
Impacted Files Coverage Δ
stacktrace.go 64.55% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vearutop vearutop marked this pull request as ready for review March 30, 2023 19:44
@vearutop vearutop merged commit aba6a68 into main Apr 3, 2023
@vearutop vearutop deleted the upd-go1.20 branch April 3, 2023 22:11
vearutop added a commit that referenced this pull request Apr 3, 2023
#549)

* Update CI for go1.20 (#552)

* fix(deps): update module github.com/cucumber/gherkin/go/v26 to v26.1.0

* Tidy modules

---------

Co-authored-by: Viacheslav Poturaev <vearutop@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
vearutop added a commit that referenced this pull request Apr 3, 2023
* fix(deps): update module github.com/cucumber/gherkin/go/v26 to v26.1.0 (#549)

* Update CI for go1.20 (#552)

* fix(deps): update module github.com/cucumber/gherkin/go/v26 to v26.1.0

* Tidy modules

---------

Co-authored-by: Viacheslav Poturaev <vearutop@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* cancel context for each scenario

* Update suite.go

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Viacheslav Poturaev <vearutop@gmail.com>
Co-authored-by: Viacheslav Poturaev <nanopeni@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Go 1.20
1 participant