Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use staticcheck GitHub Action #563

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Use staticcheck GitHub Action #563

merged 2 commits into from
Jun 6, 2023

Conversation

vearutop
Copy link
Member

🤔 What's changed?

We use staticcheck to lint the code, and so far the binary is bundled in the repo.
This PR migrates to the official GitHub Action.

Also the issues found by staticcheck are fixed.

⚡️ What's your motivation?

Currently, bundled binary is bloating the repo and makes it a bit harder to use newer versions of the tool.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@github-actions
Copy link

Go API Changes

# github.com/cucumber/godog
## compatible changes
(*ScenarioContext).Given: added
(*ScenarioContext).Then: added
(*ScenarioContext).When: added

# github.com/cucumber/godog/formatters
## compatible changes
Given: added
Keyword: added
None: added
StepDefinition.Keyword: added
Then: added
When: added

# summary
Inferred base version: v0.12.6
Suggested version: v0.13.0

@vearutop vearutop requested a review from nhatthm May 26, 2023 16:44
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #563 (bf1f997) into main (7f75c5d) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main     #563   +/-   ##
=======================================
  Coverage   82.96%   82.96%           
=======================================
  Files          28       28           
  Lines        3375     3375           
=======================================
  Hits         2800     2800           
  Misses        461      461           
  Partials      114      114           
Impacted Files Coverage Δ
internal/formatters/fmt_multi.go 96.72% <ø> (ø)
internal/formatters/undefined_snippets_gen.go 43.39% <ø> (ø)
internal/storage/storage.go 92.10% <0.00%> (ø)
internal/formatters/fmt_base.go 87.28% <100.00%> (ø)

@vearutop vearutop merged commit ea50e4b into main Jun 6, 2023
@vearutop vearutop deleted the staticcheck-gha branch June 6, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant