Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create releasing guidelines #608

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Create releasing guidelines #608

merged 1 commit into from
Feb 6, 2024

Conversation

glibas
Copy link
Member

@glibas glibas commented Jan 31, 2024

🤔 What's changed?

Adding RELEASING guidelines.

⚡️ What's your motivation?

Was hard to figure out the release process.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

Nice and simple release process, just needs documenting.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@glibas glibas requested a review from vearutop January 31, 2024 20:44
Copy link

Go API Changes

# summary
Inferred base version: v0.14.0
Suggested version: v0.14.1

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (244de82) 83.21% compared to head (45417f5) 83.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #608   +/-   ##
=======================================
  Coverage   83.21%   83.21%           
=======================================
  Files          28       28           
  Lines        3413     3413           
=======================================
  Hits         2840     2840           
  Misses        458      458           
  Partials      115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


- **MAJOR**: Incompatible API changes.
- **MINOR**: Backward-compatible new features.
- **PATCH**: Backward-compatible bug fixes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a common approach for v1+, but with current v0 we're still in officially unstable API mode (v0 is to avoid import path changes in Go module before we reach stable API). We can not use MAJOR to convey information about backwards compatibility, so a more helpful indication at the moment is to use MINOR for breaking changes and PATCH for all backwards compatible changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, got it, thanks. How about the below formulation then:

Current (for v0.MINOR.PATCH)

  • MINOR: Incompatible API changes.
  • PATCH: Backward-compatible new features and bug fixes.

After v1.X.X release

  • MAJOR: Incompatible API changes.
  • MINOR: Backward-compatible new features.
  • PATCH: Backward-compatible bug fixes.

@glibas glibas force-pushed the releasing-guide branch 2 times, most recently from 8ad1f45 to de0c95d Compare February 5, 2024 09:08
RELEASING.md Outdated
Comment on lines 34 to 39
4. **Tagging:**
- Create a new annotated tag for the release.
```
git tag -a vMAJOR.MINOR.PATCH -m "Version MAJOR.MINOR.PATCH"
```

5. **Push Changes:**
- Push the new tag to the GitHub repository.
```
git push origin vMAJOR.MINOR.PATCH
```

6. **Create Release on GitHub:**
- Go to the [Releases] page on GitHub.
- Click on "Draft a new release."
- Tag version should be set to the newly created tag.
- Title the release using the version number (e.g., "vMAJOR.MINOR.PATCH").
- Click 'Generate release notes'
Copy link
Member

@vearutop vearutop Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if these 3 steps should be simplified or not, but all them can be done with just step 6 (create release and tag a version at once).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, let's keep it simple, updated

Copy link
Member

@vearutop vearutop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@glibas glibas merged commit 27ad3c2 into main Feb 6, 2024
8 checks passed
@glibas glibas deleted the releasing-guide branch February 6, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants