Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to built-in CSS and JS files #344

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Jan 22, 2025

🤔 What's changed?

The CucumberHtmlStream ctor now has default values for the CSS and JS file paths, so consumers can call the ctor without arguments and it will work as expected with the built-in CSS and JS.

⚡️ What's your motivation?

Fixes #342.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss changed the title default to built-in CSS and JS files Default to built-in CSS and JS files Jan 22, 2025
@davidjgoss davidjgoss marked this pull request as ready for review January 22, 2025 14:35
@davidjgoss davidjgoss merged commit 98f035f into main Jan 22, 2025
14 checks passed
@davidjgoss davidjgoss deleted the html-stream-default-files branch January 22, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CucumberHtmlStream CSS and JS args should have sane defaults
1 participant