-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
internal/ci: set GOTOOLCHAIN=local as part of installGo
Installing a specific version of Go in a CI matrix has intent: i.e. we intend to use that verison for everything. The default value for GOTOOLCHAIN is 'auto'. Per: https://go.dev/doc/toolchain this has the effect of downloading other toolchains as required by go.mod files of dependencies etc. We don't want this: we want to fail in case the version intended by CI is not appropriate. The doc comment in internal/ci/base/github.cue motivates why (for now) we set this variable as part of the installGo step. TL;DR - it localises the setting of a variable pertinent only to jobs that require Go (and the installation of Go is required because it is not part of the base image on all platforms), and an environment variable approach does not work where a matrix of Go versions is involved. Signed-off-by: Paul Jolly <paul@myitcv.io> Change-Id: I3b0fa04c69dc51d75bafcdf513e0415adf85564d Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1200599 Reviewed-by: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
- Loading branch information
Showing
5 changed files
with
69 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters