-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update version of docsy to 03eede2 #215
Conversation
✔️ Deploy Preview for cue ready! 🔨 Explore the source changes: eace6e9 🔍 Inspect the deploy log: https://app.netlify.com/sites/cue/deploys/61eacdc262b04a00071b4100 😎 Browse the preview: https://deploy-preview-215--cue.netlify.app |
2f504bf
to
a4a43c9
Compare
@myitcv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting into the Chinese translation, but found some bugs of docsy, so I update it to latest version.
Wonderful, thank you for taking the initiative here!
Got some questions about the change.
Following this PR I also can't develop things locally using the version configured in:
Line 10 in 2666f04
HUGO_VERSION = "0.89.4" |
It hangs on:
$ huge serve -D
hugo: downloading modules …
Does that now need to change?
Signed-off-by: hezhaoyang <gmzhaoyang@gmail.com>
@h1z3y3 - thanks for your patience on this PR. Now merged. |
I'm the one to say thank you. I will do further work when docsy go module version is stable. |
Thanks very much! Wonderful that you are taking the initiative here. If you are starting work on translations, perhaps you could comment on via cue-lang/cue#970? That way others can help review, contribute etc? |
Okay. I'm working on translation of https://curatorials.com and I have finished some pages. It's also an awesome website introducing CUE. I'll start on cuelang.org later. But what obstructs me is that docsy i18n still has some bugs on Chinese version. It will be soon, don't worry. Thanks |
I'm getting into the Chinese translation, but found some bugs of docsy, so I update it to latest version.
There were some updates of docsy, like this added some i18n message for zh.toml, it's necessary for Chinese:
https://github.com/google/docsy/pull/826/files
What updated:
zh*.toml
i18n file, this is my PR in docsy: fix: there is no need existing two i18n/zh*.toml files google/docsy#832