Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update version of docsy to 03eede2 #215

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

h1z3y3
Copy link
Contributor

@h1z3y3 h1z3y3 commented Jan 14, 2022

I'm getting into the Chinese translation, but found some bugs of docsy, so I update it to latest version.

There were some updates of docsy, like this added some i18n message for zh.toml, it's necessary for Chinese:
https://github.com/google/docsy/pull/826/files

What updated:

  1. update the docsy to the latest version: 19e0072b
  2. import docsy as hugo module, for more information: Docsy as a Go module? google/docsy#535, and this release of docsy is the last release with submodule-only support: https://github.com/google/docsy/releases
  3. fix duplicate zh*.toml i18n file, this is my PR in docsy: fix: there is no need existing two i18n/zh*.toml files google/docsy#832

@netlify
Copy link

netlify bot commented Jan 14, 2022

✔️ Deploy Preview for cue ready!

🔨 Explore the source changes: eace6e9

🔍 Inspect the deploy log: https://app.netlify.com/sites/cue/deploys/61eacdc262b04a00071b4100

😎 Browse the preview: https://deploy-preview-215--cue.netlify.app

@h1z3y3 h1z3y3 changed the title feat: update version of docsy feat: update version of docsy to b103aad Jan 14, 2022
@h1z3y3 h1z3y3 force-pushed the update_docsy branch 2 times, most recently from 2f504bf to a4a43c9 Compare January 21, 2022 02:24
@h1z3y3 h1z3y3 changed the title feat: update version of docsy to b103aad feat: update version of docsy to 19e0072b Jan 21, 2022
@h1z3y3
Copy link
Contributor Author

h1z3y3 commented Jan 21, 2022

@myitcv
After a few days this PR was still open,
I've updated theme to the theme/docsy latest version.
Bring some good features and fix some i18n bugs, please help me to review 😊

Copy link
Member

@myitcv myitcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting into the Chinese translation, but found some bugs of docsy, so I update it to latest version.

Wonderful, thank you for taking the initiative here!

Got some questions about the change.

Following this PR I also can't develop things locally using the version configured in:

HUGO_VERSION = "0.89.4"

It hangs on:

$ huge serve -D
hugo: downloading modules …

Does that now need to change?

config/_default/config.toml Outdated Show resolved Hide resolved
Signed-off-by: hezhaoyang <gmzhaoyang@gmail.com>
@h1z3y3 h1z3y3 changed the title feat: update version of docsy to 19e0072b feat: update version of docsy to 03eede2 Jan 21, 2022
@myitcv myitcv merged commit faddf74 into cue-lang:master Jan 25, 2022
@myitcv
Copy link
Member

myitcv commented Jan 25, 2022

@h1z3y3 - thanks for your patience on this PR. Now merged.

@h1z3y3
Copy link
Contributor Author

h1z3y3 commented Jan 25, 2022

I'm the one to say thank you.
Thank you for taking CUE to the world.

I will do further work when docsy go module version is stable.

@myitcv
Copy link
Member

myitcv commented Jan 25, 2022

Thanks very much! Wonderful that you are taking the initiative here.

If you are starting work on translations, perhaps you could comment on via cue-lang/cue#970?

That way others can help review, contribute etc?

@h1z3y3
Copy link
Contributor Author

h1z3y3 commented Jan 25, 2022

Okay. I'm working on translation of https://curatorials.com and I have finished some pages. It's also an awesome website introducing CUE.

I'll start on cuelang.org later.

But what obstructs me is that docsy i18n still has some bugs on Chinese version.

It will be soon, don't worry. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants