action: remove "latest" fallback to "stable" version #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the consumer specifies that they want the "latest" CUE version, we must consult the Github API to find out what that version is. The API sometimes (but rarely) fails to give us a list of CUE's releases. This may be rate-limit related; it may be internal GitHub service errors - we're not sure. When experiencing that intermittent failure, the Action currently falls back on a known-good CUE version (0.4.0) and installs it. This is undesireable for a number of reasons, not least because it requires us to keep the fallback version updated, here in code. This commit changes that behaviour, and exposes the consumer of this Action to these intermittent failures. This strategy was proposed and agreed in cue-lang/cue#2271. Signed-off-by: Jonathan Matthews <github@hello.jonathanmatthews.com>
jpluscplusm
force-pushed
the
remove_stable_version_fallback_on_api_failure
branch
from
3431a93
to
34995cd
Compare
myitcv
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the consumer specifies that they want the "latest" CUE version, we must consult the Github API to find out what that version is. The API sometimes (but rarely) fails to give us a list of CUE's releases. This may be rate-limit related; it may be internal GitHub service errors - we're not sure.
When experiencing that intermittent failure, the Action currently falls back on a known-good CUE version (0.4.0) and installs it.
This is undesireable for a number of reasons, not least because it requires us to keep the fallback version updated, here in code.
This commit changes that behaviour, and exposes the consumer of this Action to these intermittent failures. This strategy was proposed and agreed in cue-lang/cue#2271.