all: bump to use and support node20 #16
Conversation
|
@itkq - thanks for raising this PR, and apologies for the delay in getting to this. Looks like we have a build failure if you can take a look at that? |
|
I have just pushed a commit to this PR that consolidates all the changes you made, @itkq, into a single commit. I suggest we use that as the basis for merging. I'm looking at fixing the build failure now. |
* Upgrade 'vendored' GitHub action schema to use new node20 value. * Use the latest version of actions/setup-node and actions/checkout in the workflows for this project to avoid triggering warnings about using node16-based actions. * Upgrade the action that is this repo to be node20-based. * Upgrade the version of CUE used in this repo to v0.7.1, current latest. * Bump and fix various node dependencies to get things working again. * Run 'npm ci' in workflows for this project to be more robust. This change also disables the running of the jest tests as part of CI. They are currently broken and myitcv does not have the experience to debug and fix them. We still have coverage of the code however, because the CI workflow for the project itself use the action to install CUE as part of every commit. Signed-off-by: Takuya Kosugiyama <re@itkq.jp> Co-authored-by: Paul Jolly <paul@myitcv.io>
myitcv
changed the title
|
The build failures are fixed, but the tests are failing for some reason. I have worked around this by disabling the tests as part of CI. Per the commit message, this is relatively low risk, on the basis the action itself is tested as part of the CI workflows in this repo. So for every commit, we are testing that the action behaves. |
|
@myitcv Thank you for reviewing this PR and for making the necessary commits! |
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/