Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

Allow cmd to read external data from env and command line flags #159

Closed
ukiahsmith opened this issue Oct 18, 2019 · 2 comments
Closed

Allow cmd to read external data from env and command line flags #159

ukiahsmith opened this issue Oct 18, 2019 · 2 comments
Labels
FeatureRequest New feature or request roadmap/cli Specific tag for roadmap issue #337
Milestone
v0.1.0

Comments

@ukiahsmith
Copy link

To what extent should environment variables and flags be unified?

How should the cmd command evaluate environmental variables and flags when both are specified.
@mpvl mpvl added FeedbackWanted Further information is requested FeatureRequest New feature or request NeedsDesign Functionality seems desirable, but not sure how it should look like. labels Oct 18, 2019
@mpvl mpvl added this to the v0.0.16 - cli boost milestone Dec 5, 2019
@mpvl mpvl added the roadmap/cli Specific tag for roadmap issue #337 label Dec 12, 2019
mpvl added a commit that referenced this issue Dec 19, 2019
@mpvl
pkg/tool/os: add tasks for environment variables
42346df 
These are implemented as tasks as they are state
altering and may yield different results on repeated
calls.

Also:
- Remove usage of package errors for pkgs.
- Updated go-cmp
- Fix bug in dependency analysis where default
  values could cause a dependency to be concrete
  prematurely.

Issue #159

Change-Id: I517eb6892cbeff538c806a822510ffce5dcb31b0
Reviewed-on: https://cue-review.googlesource.com/c/cue/+/4461
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
@mpvl mpvl removed FeedbackWanted Further information is requested NeedsDesign Functionality seems desirable, but not sure how it should look like. labels Dec 19, 2019
mpvl added a commit that referenced this issue Feb 17, 2020
@mpvl
cmd/cue/cmd: add --tags flag
0846b93 
The tags flag allows specifying values for fields.

Issue #190
Issue #159

Change-Id: Iddbfe8eb9fcb2a163ce773411042e020372ff8be
Reviewed-on: https://cue-review.googlesource.com/c/cue/+/4949
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
@myitcv myitcv modified the milestones: v0.0.16 - cli boost, v0.1.0 Apr 9, 2020
@mpvl
Copy link
Contributor

mpvl commented Apr 10, 2020

The tooling layer now supports environment variables.

A general mechanism for injecting values based on command lines flags is now supported through --inject/-t. This is not general command line flags, which may still be considered, but it is actually surprisingly hard to get a nice UX for. So closing this for now until --inject/-t proves insufficient.

@mpvl mpvl closed this as completed Apr 10, 2020
@buremba buremba mentioned this issue Aug 18, 2020
Closed
This was referenced Jul 3, 2021
Closed
Open
@cueckoo
Copy link

cueckoo commented Jul 3, 2021

This issue has been migrated to cue-lang/cue#159.

For more details about CUE's migration to a new home, please see cue-lang/cue#1078.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest New feature or request roadmap/cli Specific tag for roadmap issue #337
Projects
None yet
Milestone
v0.1.0
Development

No branches or pull requests
4 participants
@ukiahsmith @myitcv @mpvl @cueckoo